feat(gitlab): add GitLab API v4 client with typed responses by asaphko · Pull Request #7120 · Flagsmith/flagsmith

asaphko · 2026-04-03T13:11:52Z

Introduce the GitLab integration Django app scaffold and a typed API v4 client. This is the first PR in a stacked series splitting #7028 into reviewable increments, addressing review feedback from @khvn26, @emyller, and @Zaimwa9.

Changes

GitLab API v4 client with functions for project listing, issue/MR search, comment posting, label management, and member listing
TypedDict response types following the LaunchDarkly/Grafana pattern (addresses khvn26's feedback on generating response types)
Dataclass query parameter types for pagination, project, and issue/MR filtering
Django app scaffold registered in INSTALLED_APPS
18 tests with responses header validation and parametrised cases

Contributes to #7028

Review effort: 2/5

Review feedback addressed from #7028

TypedDict response types instead of dict[str, Any] (khvn26: "Can we generate response types from GitLab's OpenAPI schema?")
responses header validation instead of separate build_request_headers test (khvn26: "I'd rather the responses mocks validate expected headers")
Parametrised repetitive tests (Zaimwa9, khvn26: "these tests could be gathered in a single parametrised one")
Label conflict handled via status code, not exception parsing (emyller: "avoidable API crash")
Zero # type: ignore — mypy strict clean
Literal types for resource endpoint parameters (khvn26: "Consider making this a Literal")
Private helpers prefixed with _ (_build_request_headers, _build_paginated_response)
Cleaner function names: get_gitlab_resource_metadata, label_gitlab_resource
requests.params dict instead of manual URL string concatenation

🤖 Generated with Claude Code

Introduce the GitLab integration Django app with a typed API client for GitLab v4. This is the first PR in a stacked series splitting the GitLab integration (#7028) into reviewable increments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

cursor · 2026-04-03T13:11:58Z

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

vercel · 2026-04-03T13:11:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	Apr 6, 2026 8:48am
flagsmith-frontend-preview	Ignored	Preview	Apr 6, 2026 8:48am
flagsmith-frontend-staging	Ignored	Preview	Apr 6, 2026 8:48am

for more information, see https://pre-commit.ci

github-actions · 2026-04-03T13:13:07Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-e2e:pr-7120`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-api-test:pr-7120`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-7120`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-7120`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7120`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7120`	Finished ✅	Results ✅

codecov · 2026-04-03T13:17:51Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.35%. Comparing base (61ca107) to head (8e7094d).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7120      +/-   ##
==========================================
+ Coverage   98.33%   98.35%   +0.01%     
==========================================
  Files        1337     1342       +5     
  Lines       50012    50371     +359     
==========================================
+ Hits        49180    49541     +361     
+ Misses        832      830       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-04-03T13:18:16Z

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
43.9 seconds
11bf93f
🔄 Run: #15690 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
24.5 seconds
e1716f2
🔄 Run: #15691 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
50.5 seconds
11bf93f
🔄 Run: #15690 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
28.9 seconds
e1716f2
🔄 Run: #15691 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
47.4 seconds
11bf93f
🔄 Run: #15690 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

16 passed

Details

16 tests across 13 suites
33.5 seconds
11bf93f
🔄 Run: #15690 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
9.4 seconds
98f7aab
🔄 Run: #15715 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
45.3 seconds
04ad4fa
🔄 Run: #15714 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
45.5 seconds
98f7aab
🔄 Run: #15715 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

1 passed

Details

1 test across 1 suite
56 seconds
04ad4fa
🔄 Run: #15714 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 15 seconds
04ad4fa
🔄 Run: #15714 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
39 seconds
8faf925
🔄 Run: #15722 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
7.8 seconds
8faf925
🔄 Run: #15722 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
57 seconds
8faf925
🔄 Run: #15722 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

16 passed

Details

16 tests across 13 suites
28 seconds
8faf925
🔄 Run: #15722 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
42.4 seconds
18ba43a
🔄 Run: #15723 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
10.7 seconds
18ba43a
🔄 Run: #15723 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

16 passed

Details

16 tests across 13 suites
55.1 seconds
18ba43a
🔄 Run: #15723 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
58.2 seconds
18ba43a
🔄 Run: #15723 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
7 seconds
13dd9b5
🔄 Run: #15724 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
11.8 seconds
13dd9b5
🔄 Run: #15724 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
49.6 seconds
13dd9b5
🔄 Run: #15724 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
1 minute, 6 seconds
13dd9b5
🔄 Run: #15724 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

10 passed

Details

10 tests across 7 suites
40.9 seconds
8e7094d
🔄 Run: #15726 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

10 passed

Details

10 tests across 7 suites
11.4 seconds
8e7094d
🔄 Run: #15726 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

2 passed

Details

2 tests across 2 suites
56.1 seconds
8e7094d
🔄 Run: #15726 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
1 minute, 5 seconds
8e7094d
🔄 Run: #15726 (attempt 1)

Add type annotations and type: ignore comments for PaginatedResponse union type access in test assertions, IssueQueryParams dynamic kwargs, and responses.calls union attribute access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

for more information, see https://pre-commit.ci

Cover the __post_init__ validation branches for page and page_size to reach 100% diff coverage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

asaphko requested a review from a team as a code owner April 3, 2026 13:11

asaphko requested review from gagantrivedi and removed request for a team April 3, 2026 13:11

claude bot reviewed Apr 3, 2026

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

e1716f2

for more information, see https://pre-commit.ci

github-actions bot added api Issue related to the REST API feature New feature or request labels Apr 3, 2026

asaphko mentioned this pull request Apr 3, 2026

feat(gitlab): add configuration persistence and resource browsing #7121

Open

7 tasks

This was referenced Apr 3, 2026

Epic: GitLab Integration v1 #7000

Open

Spike: GitLab Integration #6725

Open

asaphko and others added 2 commits April 6, 2026 09:04

[pre-commit.ci] auto fixes from pre-commit.com hooks

98f7aab

for more information, see https://pre-commit.ci